Limit name byte length

2021-03-13 12:39:54 +10:00
parent f9809caa42
commit 36b6aafbc1
2 changed files with 7 additions and 3 deletions
--- a/bulkredditdownloader/file_name_formatter.py
+++ b/bulkredditdownloader/file_name_formatter.py
@@ -59,9 +59,10 @@ class FileNameFormatter:

    @staticmethod
    def _limit_file_name_length(filename: str, ending: str) -> str:
-        max_length = 255 - len(ending)
-        if len(filename) > max_length:
-            filename = filename[:max_length]
+        max_length_chars = 255 - len(ending)
+        max_length_bytes = 255 - len(ending.encode('utf-8'))
+        while len(filename) > max_length_chars or len(filename.encode('utf-8')) > max_length_bytes:
+            filename = filename[:-1]
        return filename + ending

    def format_resource_paths(self, resources: list[Resource],