ModerateWinGuy/BDFR_Web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bug with some Imgur extensions

Browse Source
This commit is contained in:
Serene-Arc
2021-05-19 09:55:03 +10:00
committed by Serene
parent 32f72c35ec
commit 3b28ad24b3
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bdfr/site_downloaders/imgur.py
View File

@@ -71,6 +71,7 @@ class Imgur(BaseDownloader):
@staticmethod @staticmethod
def _validate_extension(extension_suffix: str) -> str: def _validate_extension(extension_suffix: str) -> str:
extension_suffix = extension_suffix.strip('?1')
possible_extensions = ('.jpg', '.png', '.mp4', '.gif') possible_extensions = ('.jpg', '.png', '.mp4', '.gif')
selection = [ext for ext in possible_extensions if ext == extension_suffix] selection = [ext for ext in possible_extensions if ext == extension_suffix]
if len(selection) == 1: if len(selection) == 1:

9
tests/site_downloaders/test_imgur.py
View File

@@ -122,6 +122,14 @@ def test_imgur_extension_validation_bad(test_extension: str):
'029c475ce01b58fdf1269d8771d33913', '029c475ce01b58fdf1269d8771d33913',
), ),
), ),
(
'https://imgur.com/a/eemHCCK',
(
'9cb757fd8f055e7ef7aa88addc9d9fa5',
'b6cb6c918e2544e96fb7c07d828774b5',
'fb6c913d721c0bbb96aa65d7f560d385',
),
),
)) ))
def test_find_resources(test_url: str, expected_hashes: list[str]): def test_find_resources(test_url: str, expected_hashes: list[str]):
mock_download = Mock() mock_download = Mock()
@@ -131,5 +139,4 @@ def test_find_resources(test_url: str, expected_hashes: list[str]):
assert all([isinstance(res, Resource) for res in results]) assert all([isinstance(res, Resource) for res in results])
[res.download(120) for res in results] [res.download(120) for res in results]
hashes = set([res.hash.hexdigest() for res in results]) hashes = set([res.hash.hexdigest() for res in results])
assert len(results) == len(expected_hashes)
assert hashes == set(expected_hashes) assert hashes == set(expected_hashes)