diff --git a/bdfr/downloader.py b/bdfr/downloader.py index 001a079..adfadcb 100644 --- a/bdfr/downloader.py +++ b/bdfr/downloader.py @@ -57,10 +57,15 @@ class RedditDownloader(RedditConnector): f'Submission {submission.id} in {submission.subreddit.display_name} skipped' f' due to {submission.author.name if submission.author else "DELETED"} being an ignored user') return - elif submission.score < self.args.min_score or self.args.max_score < submission.score: - logger.debug(f"Submission {submission.id} filtered due to score {submission.score} < {self.args.min_score}") + elif self.args.min_score and submission.score < self.args.min_score: + logger.debug(f"Submission {submission.id} filtered due to score {submission.score} < [{self.args.min_score}]") return - elif submission.upvote_ratio < self.args.min_score_ratio or self.args.max_score_ratio < submission.upvote_ratio: + elif self.args.max_score and self.args.max_score < submission.score: + logger.debug(f"Submission {submission.id} filtered due to score [{self.args.max_score}] < {submission.score}") + return + elif (self.args.min_score_ratio and submission.upvote_ratio < self.args.min_score_ratio) or ( + self.args.max_score_ratio and self.args.max_score_ratio < submission.upvote_ratio + ): logger.debug(f"Submission {submission.id} filtered due to score ratio ({submission.upvote_ratio})") return elif not isinstance(submission, praw.models.Submission):