From 735833503fd7e42dbd9f33bc42a9150921a42498 Mon Sep 17 00:00:00 2001
From: Serene-Arc <serenical@gmail.com>
Date: Mon, 8 Mar 2021 12:52:53 +1000
Subject: [PATCH] Fix wrong if condition

---
 bulkredditdownloader/downloader.py | 39 +++++++++++++++---------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/bulkredditdownloader/downloader.py b/bulkredditdownloader/downloader.py
index 1fd3bb7..aeb88ab 100644
--- a/bulkredditdownloader/downloader.py
+++ b/bulkredditdownloader/downloader.py
@@ -181,26 +181,27 @@ class RedditDownloader:
             return []
 
     def _get_user_data(self) -> list[Iterator]:
-        if self.args.user:
-            if not self._check_user_existence(self.args.user):
-                raise errors.RedditUserError(f'User {self.args.user} does not exist')
-            generators = []
-            sort_function = self._determine_sort_function()
-            if self.args.submitted:
-                generators.append(
-                    sort_function(
-                        self.reddit_instance.redditor(self.args.user).submissions,
-                        limit=self.args.limit))
-            if not self.authenticated and any((self.args.upvoted, self.args.saved)):
-                raise errors.RedditAuthenticationError('Accessing user lists requires authentication')
+        if any([self.args.submitted, self.args.upvoted, self.args.saved]):
+            if self.args.user:
+                if not self._check_user_existence(self.args.user):
+                    raise errors.RedditUserError(f'User {self.args.user} does not exist')
+                generators = []
+                sort_function = self._determine_sort_function()
+                if self.args.submitted:
+                    generators.append(
+                        sort_function(
+                            self.reddit_instance.redditor(self.args.user).submissions,
+                            limit=self.args.limit))
+                if not self.authenticated and any((self.args.upvoted, self.args.saved)):
+                    raise errors.RedditAuthenticationError('Accessing user lists requires authentication')
+                else:
+                    if self.args.upvoted:
+                        generators.append(self.reddit_instance.redditor(self.args.user).upvoted)
+                    if self.args.saved:
+                        generators.append(self.reddit_instance.redditor(self.args.user).saved)
+                return generators
             else:
-                if self.args.upvoted:
-                    generators.append(self.reddit_instance.redditor(self.args.user).upvoted)
-                if self.args.saved:
-                    generators.append(self.reddit_instance.redditor(self.args.user).saved)
-            return generators
-        else:
-            raise errors.BulkDownloaderException('A user must be supplied to download user data')
+                raise errors.BulkDownloaderException('A user must be supplied to download user data')
 
     def _check_user_existence(self, name: str) -> bool:
         user = self.reddit_instance.redditor(name=name)