ModerateWinGuy/BDFR_Web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #633 from chapmanjacobd/patch-3

Browse Source 
fix: Redirect to /subreddits/search
This commit is contained in:
Serene
2022-07-17 11:17:52 +10:00
committed by GitHub
parent 59e57cee84 7100291ed9
commit 8ab13b4480
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bdfr/connector.py
View File

@@ -414,7 +414,9 @@ class RedditConnector(metaclass=ABCMeta):
try: try:
assert subreddit.id assert subreddit.id
except prawcore.NotFound: except prawcore.NotFound:
raise errors.BulkDownloaderException(f'Source {subreddit.display_name} does not exist or cannot be found') raise errors.BulkDownloaderException(f"Source {subreddit.display_name} cannot be found")
except prawcore.Redirect:
raise errors.BulkDownloaderException(f"Source {subreddit.display_name} does not exist")
except prawcore.Forbidden: except prawcore.Forbidden:
raise errors.BulkDownloaderException(f'Source {subreddit.display_name} is private and cannot be scraped') raise errors.BulkDownloaderException(f'Source {subreddit.display_name} is private and cannot be scraped')

3
tests/test_connector.py
View File

@@ -447,7 +447,8 @@ def test_check_user_existence_banned(
@pytest.mark.reddit @pytest.mark.reddit
@pytest.mark.parametrize(('test_subreddit_name', 'expected_message'), ( @pytest.mark.parametrize(('test_subreddit_name', 'expected_message'), (
('donaldtrump', 'cannot be found'), ('donaldtrump', 'cannot be found'),
('submitters', 'private and cannot be scraped') ('submitters', 'private and cannot be scraped'),
('lhnhfkuhwreolo', 'does not exist')
)) ))
def test_check_subreddit_status_bad(test_subreddit_name: str, expected_message: str, reddit_instance: praw.Reddit): def test_check_subreddit_status_bad(test_subreddit_name: str, expected_message: str, reddit_instance: praw.Reddit):
test_subreddit = reddit_instance.subreddit(test_subreddit_name) test_subreddit = reddit_instance.subreddit(test_subreddit_name)