Tighten exception block
This commit is contained in:
@@ -194,9 +194,14 @@ class RedditDownloader:
|
|||||||
def _download_submission(self, submission: praw.models.Submission):
|
def _download_submission(self, submission: praw.models.Submission):
|
||||||
if self.download_filter.check_url(submission.url):
|
if self.download_filter.check_url(submission.url):
|
||||||
logger.debug('Attempting to download submission {}'.format(submission.id))
|
logger.debug('Attempting to download submission {}'.format(submission.id))
|
||||||
|
|
||||||
try:
|
try:
|
||||||
downloader_class = DownloadFactory.pull_lever(submission.url)
|
downloader_class = DownloadFactory.pull_lever(submission.url)
|
||||||
downloader = downloader_class(submission)
|
downloader = downloader_class(submission)
|
||||||
|
except NotADownloadableLinkError as e:
|
||||||
|
logger.error('Could not download submission {}: {}'.format(submission.name, e))
|
||||||
|
return
|
||||||
|
|
||||||
if self.args.no_download:
|
if self.args.no_download:
|
||||||
logger.info('Skipping download for submission {}'.format(submission.id))
|
logger.info('Skipping download for submission {}'.format(submission.id))
|
||||||
else:
|
else:
|
||||||
@@ -218,5 +223,3 @@ class RedditDownloader:
|
|||||||
logger.debug(f'Resource from {res.url} downloaded elsewhere')
|
logger.debug(f'Resource from {res.url} downloaded elsewhere')
|
||||||
|
|
||||||
logger.info('Downloaded submission {}'.format(submission.name))
|
logger.info('Downloaded submission {}'.format(submission.name))
|
||||||
except NotADownloadableLinkError as e:
|
|
||||||
logger.error('Could not download submission {}: {}'.format(submission.name, e))
|
|
||||||
|
|||||||
Reference in New Issue
Block a user