Lint run

Linting run through various things. Mostly markdownlint.

scripts/README.md

@@ -2,10 +2,10 @@
 
 Due to the verboseness of the logs, a great deal of information can be gathered quite easily from the BDFR's logfiles. In this folder, there is a selection of scripts that parse these logs, scraping useful bits of information. Since the logfiles are recurring patterns of strings, it is a fairly simple matter to write scripts that utilise tools included on most Linux systems.
 
-  - [Script to extract all successfully downloaded IDs](#extract-all-successfully-downloaded-ids)
-  - [Script to extract all failed download IDs](#extract-all-failed-ids)
-  - [Timestamp conversion](#converting-bdfrv1-timestamps-to-bdfrv2-timestamps)
-  - [Printing summary statistics for a run](#printing-summary-statistics)
+- [Script to extract all successfully downloaded IDs](#extract-all-successfully-downloaded-ids)
+- [Script to extract all failed download IDs](#extract-all-failed-ids)
+- [Timestamp conversion](#converting-bdfrv1-timestamps-to-bdfrv2-timestamps)
+- [Printing summary statistics for a run](#printing-summary-statistics)
 
 ## Extract all Successfully Downloaded IDs
 
@@ -58,7 +58,7 @@ A simple script has been included to print sumamry statistics for a run of the B
 
 This will create an output like the following:
 
-```
+```text
 Downloaded submissions: 250
 Failed downloads: 103
 Files already downloaded: 20073

scripts/extract_failed_ids.ps1

@@ -1,21 +1,21 @@
 if (Test-Path -Path $args[0] -PathType Leaf) {
-	$file=$args[0]
+    $file=$args[0]
 }
 else {
-	Write-Host "CANNOT FIND LOG FILE"
-	Exit 1
+    Write-Host "CANNOT FIND LOG FILE"
+    Exit 1
 }
 
-if ($args[1] -ne $null) {
-	$output=$args[1]
-	Write-Host "Outputting IDs to $output"
+if ($null -ne $args[1]) {
+    $output=$args[1]
+    Write-Host "Outputting IDs to $output"
 }
 else {
-	$output="./failed.txt"
+    $output="./failed.txt"
 }
 
-Select-String -Path $file -Pattern "Could not download submission" | ForEach-Object { -split $_.Line | Select-Object -Skip 11 | Select-Object -First 1 } | foreach { $_.substring(0,$_.Length-1) } >> $output
+Select-String -Path $file -Pattern "Could not download submission" | ForEach-Object { -split $_.Line | Select-Object -Skip 11 | Select-Object -First 1 } | ForEach-Object { $_.substring(0,$_.Length-1) } >> $output
 Select-String -Path $file -Pattern "Failed to download resource" | ForEach-Object { -split $_.Line | Select-Object -Skip 14 | Select-Object -First 1 } >> $output
-Select-String -Path $file -Pattern "failed to download submission" | ForEach-Object { -split $_.Line | Select-Object -Skip 13 | Select-Object -First 1 } | foreach { $_.substring(0,$_.Length-1) } >> $output
+Select-String -Path $file -Pattern "failed to download submission" | ForEach-Object { -split $_.Line | Select-Object -Skip 13 | Select-Object -First 1 } | ForEach-Object { $_.substring(0,$_.Length-1) } >> $output
 Select-String -Path $file -Pattern "Failed to write file" | ForEach-Object { -split $_.Line | Select-Object -Skip 13 | Select-Object -First 1 } >> $output
 Select-String -Path $file -Pattern "skipped due to disabled module" | ForEach-Object { -split $_.Line | Select-Object -Skip 8 | Select-Object -First 1 } >> $output

scripts/extract_successful_ids.ps1

@@ -1,17 +1,17 @@
 if (Test-Path -Path $args[0] -PathType Leaf) {
-	$file=$args[0]
+    $file=$args[0]
 }
 else {
-	Write-Host "CANNOT FIND LOG FILE"
-	Exit 1
+    Write-Host "CANNOT FIND LOG FILE"
+    Exit 1
 }
 
-if ($args[1] -ne $null) {
-	$output=$args[1]
-	Write-Host "Outputting IDs to $output"
+if ($null -ne $args[1]) {
+    $output=$args[1]
+    Write-Host "Outputting IDs to $output"
 }
 else {
-	$output="./successful.txt"
+    $output="./successful.txt"
 }
 
 Select-String -Path $file -Pattern "Downloaded submission" | ForEach-Object { -split $_.Line | Select-Object -Last 3 | Select-Object -SkipLast 2 } >> $output

scripts/print_summary.ps1

@@ -1,17 +1,17 @@
 if (Test-Path -Path $args[0] -PathType Leaf) {
-	$file=$args[0]
+    $file=$args[0]
 }
 else {
-	Write-Host "CANNOT FIND LOG FILE"
-	Exit 1
+    Write-Host "CANNOT FIND LOG FILE"
+    Exit 1
 }
 
-if ($args[1] -ne $null) {
-	$output=$args[1]
-	Write-Host "Outputting IDs to $output"
+if ($null -ne $args[1]) {
+    $output=$args[1]
+    Write-Host "Outputting IDs to $output"
 }
 else {
-	$output="./successful.txt"
+    $output="./successful.txt"
 }
 
 Write-Host -NoNewline "Downloaded submissions: "

scripts/tests/example_logfiles/failed_resource_error.txt

@@ -1,2 +1 @@
 [2021-06-12 11:18:25,794 - bdfr.downloader - ERROR] - Failed to download resource https://i.redd.it/61fniokpjq471.jpg in submission nxv3dt with downloader Direct: Unrecoverable error requesting resource: HTTP Code 404
-

scripts/tests/example_logfiles/succeed_score_filter.txt

@@ -1,2 +1,2 @@
 [2022-07-23 14:04:14,095 - bdfr.downloader - DEBUG] - Submission ljyy27 filtered due to score 15 < [50]
-[2022-07-23 14:04:14,104 - bdfr.downloader - DEBUG] - Submission ljyy27 filtered due to score 16 > [1]
+[2022-07-23 14:04:14,104 - bdfr.downloader - DEBUG] - Submission ljyy27 filtered due to score 16 > [1]