Fix wrong if condition

This commit is contained in:
Serene-Arc
2021-03-08 12:52:53 +10:00
committed by Ali Parlakci
parent 862121cac6
commit 735833503f

View File

@@ -181,26 +181,27 @@ class RedditDownloader:
return [] return []
def _get_user_data(self) -> list[Iterator]: def _get_user_data(self) -> list[Iterator]:
if self.args.user: if any([self.args.submitted, self.args.upvoted, self.args.saved]):
if not self._check_user_existence(self.args.user): if self.args.user:
raise errors.RedditUserError(f'User {self.args.user} does not exist') if not self._check_user_existence(self.args.user):
generators = [] raise errors.RedditUserError(f'User {self.args.user} does not exist')
sort_function = self._determine_sort_function() generators = []
if self.args.submitted: sort_function = self._determine_sort_function()
generators.append( if self.args.submitted:
sort_function( generators.append(
self.reddit_instance.redditor(self.args.user).submissions, sort_function(
limit=self.args.limit)) self.reddit_instance.redditor(self.args.user).submissions,
if not self.authenticated and any((self.args.upvoted, self.args.saved)): limit=self.args.limit))
raise errors.RedditAuthenticationError('Accessing user lists requires authentication') if not self.authenticated and any((self.args.upvoted, self.args.saved)):
raise errors.RedditAuthenticationError('Accessing user lists requires authentication')
else:
if self.args.upvoted:
generators.append(self.reddit_instance.redditor(self.args.user).upvoted)
if self.args.saved:
generators.append(self.reddit_instance.redditor(self.args.user).saved)
return generators
else: else:
if self.args.upvoted: raise errors.BulkDownloaderException('A user must be supplied to download user data')
generators.append(self.reddit_instance.redditor(self.args.user).upvoted)
if self.args.saved:
generators.append(self.reddit_instance.redditor(self.args.user).saved)
return generators
else:
raise errors.BulkDownloaderException('A user must be supplied to download user data')
def _check_user_existence(self, name: str) -> bool: def _check_user_existence(self, name: str) -> bool:
user = self.reddit_instance.redditor(name=name) user = self.reddit_instance.redditor(name=name)