Commit Graph
3 Commits
Author SHA1 Message Date
fc42afbabe (maint) code clean up (#187)
## bdfr

- Add the bound instance as method parameter
- Change methods not using its bound instance to staticmethods
- Fix dangerous default argument
- Refactor the comparison involving `not`
- Refactor unnecessary `else` / `elif` when `if` block has a `raise` statement
- Refactor unnecessary `else` / `elif` when `if` block has a `return` statement
- Refactor useless `else` block in the loop
- Remove implicit `object` from the base class
- Remove reimported module
- Remove unnecessary generator
- Remove unnecessary return statement
- Remove unnecessary use of comprehension
- Remove unused imports
- Use `is` to compare type of objects
- Using not x can cause unwanted results

## Dockerfile

- use a pinned Python version tag instead of latest
- leverage cached requirements

Signed-off-by: Vladislav Doster <mvdoster@gmail.com>

Co-authored-by: Ali Parlakçı <parlakciali@gmail.com>
2021-02-25 12:32:06 +03:00
vlad dosterandGitHub d731613f8a Merge pull request #191 from aliparlakci/vladdoster-patch-1
(bug) default to python3
2021-02-22 11:06:31 -06:00
vlad dosterandGitHub 41bc2db10a (bug) default to python3
- set shebang to python3 or else it errors if python2 is on users system
2021-02-22 02:28:30 -06:00